Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Room header: make room details toggle accessible by keyboard #11951

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Room header: make room details toggle accessible by keyboard #11951

merged 2 commits into from
Nov 29, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Nov 28, 2023 •
edited by github-actions bot
Loading

Fixes element-hq/element-web#26656

Screenshot 2023-11-28 at 16 00 40

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

@kerryarchibald kerryarchibald requested a review from a team as a code owner November 28, 2023 03:13
@kerryarchibald kerryarchibald added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Nov 28, 2023
@kerryarchibald kerryarchibald added this pull request to the merge queue Nov 28, 2023
Merged via the queue into develop with commit cd985d6 Nov 29, 2023
20 checks passed
@kerryarchibald kerryarchibald deleted the kerry/26656/room-header-a11y branch November 29, 2023 00:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@florianduros florianduros florianduros approved these changes

@richvdh richvdh Awaiting requested review from richvdh richvdh is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A11y: room header itself not reachable via keyboard
2 participants
@kerryarchibald @florianduros