Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Revert "Make EC widget theme reactive - Update widget url when the theme changes" #12382

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Revert "Make EC widget theme reactive - Update widget url when the theme changes" #12382

merged 1 commit into from
Mar 28, 2024

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Mar 28, 2024 •
edited by dbkr
Loading

Reverts #12295 due to element-hq/element-integration-manager#116

The eventual fix will be #12381 but we're not ready yet.

Fixes element-hq/element-web#27249

@Half-Shot Half-Shot requested a review from a team as a code owner March 28, 2024 11:01
@Half-Shot Half-Shot requested review from dbkr and florianduros March 28, 2024 11:01
@Half-Shot Half-Shot added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Mar 28, 2024
@dbkr dbkr added X-Release-Blocker This affects the current release cycle and must be solved for a release to happen backport staging Label to automatically backport PR to staging branch labels Mar 28, 2024
@dbkr dbkr added this pull request to the merge queue Mar 28, 2024
Merged via the queue into develop with commit 75a989e Mar 28, 2024
40 of 41 checks passed
@dbkr dbkr deleted the revert-12295-toger5/reactive-widget-theme-url branch March 28, 2024 12:27
RiotRobot pushed a commit that referenced this pull request Mar 28, 2024
@Half-Shot @github-actions
Revert "Make EC widget theme reactive - Update widget url when the th…
2603003 
…eme chan…" (#12382)

This reverts commit c42562e.

(cherry picked from commit 75a989e)
@RiotRobot RiotRobot mentioned this pull request Mar 28, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@toger5 toger5 toger5 approved these changes

@dbkr dbkr dbkr approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
backport staging Label to automatically backport PR to staging branch T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems X-Release-Blocker This affects the current release cycle and must be solved for a release to happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing access token for widgets
3 participants
@Half-Shot @dbkr @toger5