Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Implement the "Voice & Video" tab of new user settings #2498

Merged
merged 5 commits into from
Jan 24, 2019
Merged

Implement the "Voice & Video" tab of new user settings #2498

merged 5 commits into from
Jan 24, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live requested a review from a team January 24, 2019 20:43
@jryans jryans self-assigned this Jan 24, 2019
jryans
jryans approved these changes Jan 24, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks! 😁

src/components/views/settings/tabs/VoiceSettingsTab.js Show resolved Hide resolved
@jryans jryans assigned turt2live and unassigned jryans Jan 24, 2019
@turt2live turt2live assigned jryans and unassigned turt2live Jan 24, 2019
@turt2live turt2live requested a review from jryans January 24, 2019 21:41
@turt2live
Copy link
Member Author

turt2live commented Jan 24, 2019 •
edited
Loading

@jryans should be better now - please take another look.

image

jryans
jryans approved these changes Jan 24, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks more polished now. Thanks! 😁

@jryans jryans assigned turt2live and unassigned jryans Jan 24, 2019
@turt2live turt2live merged commit c5deeea into experimental Jan 24, 2019
@turt2live turt2live deleted the travis/usettings/tab/voice branch January 24, 2019 21:59
@turt2live turt2live mentioned this pull request Jan 24, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jryans jryans jryans approved these changes

Assignees

@turt2live turt2live

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @jryans