This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix AliasSettings and RelatedGroups UX #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improves upon the general UX to be a bit friendlier for direct manipulation things.
Instead of rendering it as a span with no label.
40 tasks
jryans
approved these changes
Feb 22, 2019
| .mx_EditableItemList_newItem .mx_Field input { | ||
| // Use 100% of the space available for the input, but don't let the 10px | ||
| // padding on either side of the input to push it out of alignment. | ||
| width: calc(100% - 20px); |
There was a problem hiding this comment.
Nope - tried border-box, padding-box, and content-box and all 3 have very similar results.
This was referenced Feb 22, 2019
Remove related community button shown to those who don't have permission
element-hq/element-web#5634
Closed
Closed
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#8803
Fixes element-hq/element-web#8740
Fixes element-hq/element-web#8640
Fixes element-hq/element-web#8783 (by removing it)
Fixes element-hq/element-web#8591
Fixes element-hq/element-web#8101 (by not allowing editing)
Fixes element-hq/element-web#6341 (by using a different component for inputs)
Fixes element-hq/element-web#5634
This mirrors a UX similar to 3pids in order to better make use of the
<Field>component. Inline editing was removed because it makes things a little too complicated for direct manipulation, and the UX is undefined for inline save buttons. Instead, a flow for delete + add is provided which is much easier to support for direct manipulation and to represent.In addition to all of the above, the affected components have been converted to classes (sorry) because it's something we want to do anyways and the bulk of the component is being modified here anyways. It also magically fixes some
thiscontext errors that were encountered when using the oldercreateClassapproach (despite trying fat arrows).Below is a preview of the UX. If you look carefully behind the dialog, you'll see things moving in the timeline and in the room name.