This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Provide an escape from the registration process #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#6560 Would be better improved by matrix-org/matrix-spec-proposals#1921 or similar in the future.
bwindels
approved these changes
Mar 12, 2019
| @@ -549,6 +560,15 @@ module.exports = React.createClass({ | |||
| { _t('Sign in instead') } | |||
| </a>; | |||
|
|
|||
| let goBack = <a className="mx_AuthBody_changeFlow" onClick={this.onGoToFormClicked} href="#"> | |||
There was a problem hiding this comment.
nit: only assign goBack if it'll be used? let foo; if (bar) foo = <div/> is also the pattern we use elsewhere.
There was a problem hiding this comment.
it seemed a bit weird to have it default off when the majority of cases use it, but I also agree that going against the grain here is more confusing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#6560
Would be better improved by matrix-org/matrix-spec-proposals#1921 or similar in the future.