This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Handle all the segments of a v3 event ID #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They may contain slashes, so it is not suitable to just pull the first segment after the room ID. Instead, we just recompile the event ID from known source, assuming everything afterwards is an event ID. Fixes element-hq/element-web#8315 This will need adapting to support element-hq/element-web#9149
dbkr
reviewed
Mar 27, 2019
| @@ -1561,7 +1561,16 @@ export default React.createClass({ | |||
| } else if (screen.indexOf('room/') == 0) { | |||
| const segments = screen.substring(5).split('/'); | |||
| const roomString = segments[0]; | |||
| const eventId = segments[1]; // undefined if no event id given | |||
| let eventId = segments.splice(1).join("/"); // empty string if no event id given | |||
There was a problem hiding this comment.
would screen.substring(5).split('/', 1) be shorter / clearer / faster?
There was a problem hiding this comment.
This wouldn't fix the problem:
(note: part2 goes missing)
There was a problem hiding this comment.
oh yes, I forgot / failed to realise that js's string.split is different and less useful than string.split in any other language :/
dbkr
approved these changes
Mar 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They may contain slashes, so it is not suitable to just pull the first segment after the room ID. Instead, we just recompile the event ID from known source, assuming everything afterwards is an event ID.
Fixes element-hq/element-web#8315
This will need adapting to support element-hq/element-web#9149