Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Mark a few CSS classes as not selectable #2929

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Mark a few CSS classes as not selectable #2929

merged 1 commit into from
Apr 23, 2019

Conversation

z3ntu
Copy link
Contributor

@z3ntu z3ntu commented Apr 21, 2019 •
edited
Loading

Should be enough to make copy-pasting not a nightmare.

For element-hq/element-web#7460

The different prefixed versions of user-select are missing which I'll add if the PR is wanted :) Done

@jryans
Copy link
Collaborator

jryans commented Apr 23, 2019

Thanks for the contribution! I know this is a small change, but even so, we'll need you to sign off the change.

Please update the PR or each commit with your sign off as described in CONTRIBUTING.rst.

@z3ntu
Copy link
Contributor Author

z3ntu commented Apr 23, 2019

@jryans Done

@z3ntu z3ntu mentioned this pull request Apr 23, 2019
Closed
jryans
jryans suggested changes Apr 23, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! 😁 It seems like a great enhancement to have. I know I have definitely been annoyed by the avatar being included by copies for sure!

One small change, and then I think we can merge this.

res/css/views/rooms/_EventTile.scss Outdated Show resolved Hide resolved
@jryans jryans self-requested a review April 23, 2019 15:03
@z3ntu
Copy link
Contributor Author

z3ntu commented Apr 23, 2019

Also putting it on mx_BaseAvatar_image or mx_BaseAvatar should be good but I'm not sure which one of those should get the attribute

image
Also looking at what is selectable currently, I think everything outside of the inner messages view should not be selectable, but that's for another day :)

@jryans
Copy link
Collaborator

jryans commented Apr 23, 2019

I would suggest mx_BaseAvatar to avoid selection of both images and first-letter avatar text.

@z3ntu
Mark a few CSS classes as not selectable
12f92c4 
Should be enough to make copy-pasting not a nightmare.

For element-hq/element-web#7460

Also remove an instance where the vendor prefixes were used, but a build
step adds those automatically

Signed-off-by: Luca Weiss <[email protected]>
@z3ntu
Copy link
Contributor Author

z3ntu commented Apr 23, 2019

Done. Good enough for me for now :)

jryans
jryans approved these changes Apr 23, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me! 😁

@jryans jryans merged commit 0e5e622 into matrix-org:develop Apr 23, 2019
@z3ntu z3ntu mentioned this pull request Apr 23, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@z3ntu @jryans