This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use alt_aliases for pills and autocomplete #4102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but don't match on name otherwise you see multiple entries per room when searching for a room name Also pass the roomId to the composer autocomplete, so it's easier to we don't need to loop through all the rooms and it's also easier accept room with local aliases as well in the future
when deserializing a pill
otherwise, display as the label in the link
foldleft
approved these changes
Feb 24, 2020
|
On localhost, it's working fine but after building and run it on our server we are not able to switch rooms: |
|
sounds like a stale js-sdk @jsonjuri |
That's correct, it is solved now, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-js-sdk#1225
Fixes element-hq/element-web#12364
As explained in MSC2432,
m.room.aliasesare being retired. Moderators can setalt_aliaseson the canonical alias event to support more than 1 moderated alias (note that there is no UI for this yet). Clients can query the local aliases of a HS through a new /aliases endpoint but should really not show these by default as they are an abuse vector.So, this PR:
alt_aliasesin addition to the canonical alias to autocompleteIdeally, we'd also add exact matches for local aliases to the autocomplete, so you would be able to send pills for non-moderated aliases from riot, but that proved a bit harder, so let's defer that until it's obvious we need it.