This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make auth argument in the register request compliant with r0.6.0 #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so accepted null for the auth part of the registration request object Took 18 minutes
|
@turt2live any chance that you can give me a hint why the dialog in the end to end tests might be affected by my change? I don't really see the connection but I might miss something |
|
Looks like it isn't, just our tests being flakey |
|
Ok I dont have any further commits in that case :) |
turt2live
suggested changes
Apr 8, 2020
Co-Authored-By: Travis Ralston <[email protected]>
…d be auth: {}
Took 16 minutes
… into fix-register-auth-with-new-spec
|
@turt2live no problem. Will fix the comment on the js-sdk companion pr too. But I think that will take longer as I need to find where this specific case actually happens. Looking at this now I realise that that check was more a hack than a solution ^^ |
Took 3 minutes
… into fix-register-auth-with-new-spec
turt2live
added
the
X-Release-Blocker
jryans
approved these changes
Jun 2, 2020
|
(Merged now as this was our last release blocker, and I'd like to start the RC process.) |
aaronraimist
added a commit
to aaronraimist/riot-ios
that referenced
this pull request
Feb 6, 2022
Web PR: matrix-org/matrix-react-sdk#4347 Signed-off-by: Aaron Raimist <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change requires: matrix-org/matrix-js-sdk#1304
This fix is tested with synapse and works fine on matrix.org!
This fix is required for https://git.koesters.xyz/timo/matrixserver which implements the r0.6.0 spec. In that spec version it says that auth shouldn't be
auth: {}but rather not be present. This fix should fix this. I tested it both with synapse and the linked server to check that everything still worksSigned-off-by: Marcel Radzio[email protected]