This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Convert /structures to TS
#6787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
T-Task
Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
force-pushed
the
task/structures-ts
branch
from
dd05631 to
4673e1a
Compare
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
force-pushed
the
task/structures-ts
branch
4 times, most recently
from
316f3b2 to
55b2420
Compare
SimonBrandner
commented
Sep 12, 2021
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
force-pushed
the
task/structures-ts
branch
from
55b2420 to
1590fe3
Compare
t3chguy
reviewed
Sep 13, 2021
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
t3chguy
approved these changes
Sep 16, 2021
| private unmounted = true; | ||
| private dispatcherRef: string; | ||
| private unmounted = false; | ||
| private dispatcherRef: string = null; |
There was a problem hiding this comment.
the = null isn't required but also not an issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: task
This leaves out the Group components and custom tag components for obvious reasons
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://6140dd36e5434e09bf306521--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.