-
-
Notifications
You must be signed in to change notification settings - Fork 829
Initial implementation: SetDisplayName -> SetMxIdDialog #849
Conversation
- Replaces SetDisplayNameDialog with SetMxIdDialog. This new dialog will use InteractiveAuth to authenticate a user with their chosen mxid. De-scoped: - style tweaks for the InteractiveAuth in the dialog (capcha) and error message. - checking for mxid availability
@@ -0,0 +1,153 @@ | |||
/* | |||
Copyright 2016 OpenMarket Ltd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copyright
}, | ||
|
||
_generateAndCachePassword: function() { | ||
const pass = Math.random().toString(36).slice(2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I guess so!
|
||
return this._matrixClient.register( | ||
this.state.username, | ||
this._generateAndCachePassword(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So here you're setting the password before the account is registered (and overwriting it with a new one for each time we try to register). It feels like it really ought to be set along with the access token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, agreed
Oh also you seem to have met our new friend, |
So that we don't overwrite the existing one every time we try to register.
It looks like |
De-scoped:
For now, based on element-hq/element-web#3604 (comment)