Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Make threads disabled by default #9810

Merged
merged 4 commits into from
Dec 21, 2022
Merged

Make threads disabled by default #9810

merged 4 commits into from
Dec 21, 2022

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Dec 21, 2022 •
edited by github-actions bot
Loading

Just in case.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@germain-gg germain-gg added T-Task Refactoring, enabling or disabling functionality, other engineering tasks backport staging Label to automatically backport PR to staging branch labels Dec 21, 2022
@germain-gg germain-gg marked this pull request as ready for review December 21, 2022 09:45
@germain-gg germain-gg requested a review from a team as a code owner December 21, 2022 09:45
@richvdh richvdh changed the title Make threads disable by default Make threads disabled by default Dec 21, 2022
richvdh
richvdh approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be failing CI? maybe that's expected though.

Should it have a changelog entry? Or should we update the changelog entry that initially enabled threads by default?

@germain-gg
Copy link
Contributor Author

@matrix-org/element-web-app-team Can we pull out #9736 from the changelog during the release?

@t3chguy t3chguy merged commit 134e3d7 into develop Dec 21, 2022
@t3chguy t3chguy deleted the gsouquet/disable-threads-by-default branch December 21, 2022 15:53
@RiotRobot RiotRobot mentioned this pull request Dec 21, 2022
Merged
RiotRobot pushed a commit that referenced this pull request Dec 21, 2022
@github-actions
Make threads disabled by default (#9810)
bd903ca 
* Make threads disable by default

* restore e2ee tests

* fix threads e2e spec for beta joining

(cherry picked from commit 134e3d7)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
backport staging Label to automatically backport PR to staging branch T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@germain-gg @richvdh @t3chguy