Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix broadcast pre-recording check #9834

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Fix broadcast pre-recording check #9834

merged 2 commits into from
Dec 28, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Dec 28, 2022 •
edited
Loading

Fixes missing await for broadcast preconditions check

closes element-hq/element-web#24099

PSF-1814

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Dec 28, 2022
@weeman1337 weeman1337 marked this pull request as ready for review December 28, 2022 12:59
@weeman1337 weeman1337 requested a review from a team as a code owner December 28, 2022 12:59
@weeman1337 weeman1337 enabled auto-merge (squash) December 28, 2022 14:26
@weeman1337 weeman1337 merged commit 100b1d5 into develop Dec 28, 2022
@weeman1337 weeman1337 deleted the weeman1337/fix-broadcast-pre-recording branch December 28, 2022 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@artcodespace artcodespace artcodespace approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected PIP widget at the end of a voice broadcast recording
2 participants
@weeman1337 @artcodespace