This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Factor out MessageEvent.from() usage
#9882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class/function is disappearing from the events-sdk, at least in this form.
turt2live
added
the
T-Task
The utility function is out of range of the calling code at runtime, for some reason.
turt2live
added a commit
that referenced
this pull request
Jan 10, 2023
This reverts commit c09ca7b.
turt2live
added a commit
that referenced
this pull request
Jan 10, 2023
This reverts commit 99e38ca.
This was referenced Jan 11, 2023
Closed
andybalaam
pushed a commit
to andybalaam/matrix-react-sdk
that referenced
this pull request
Jan 12, 2023
* Factor out `MessageEvent.from()` usage The class/function is disappearing from the events-sdk, at least in this form. * Manually create contents for events used by cypress The utility function is out of range of the calling code at runtime, for some reason. * Run prettier * Maybe this will fix the build
andybalaam
pushed a commit
to andybalaam/matrix-react-sdk
that referenced
this pull request
Jan 12, 2023
This reverts commit c09ca7b.
andybalaam
pushed a commit
to andybalaam/matrix-react-sdk
that referenced
this pull request
Jan 12, 2023
…)"" This reverts commit 99e38ca.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class/function is disappearing from the events-sdk, at least in this form.
This change is marked as an internal change (Task), so will not be included in the changelog.