FFI: Update the power levels of multiple users at once. #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
requested review from
bnjbvr and
jmartinesp
and removed request for
a team
pixlwave
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3177 +/- ##
=======================================
Coverage 83.85% 83.85%
=======================================
Files 232 232
Lines 23938 23938
=======================================
Hits 20074 20074
Misses 3864 3864 ☔ View full report in Codecov by Sentry. |
bnjbvr
approved these changes
Feb 29, 2024
|
Yep yep thank you. I wasn’t sure if it was preferable to put the type in the declaration or in the |
bnjbvr
force-pushed
the
doug/multi-user-power-levels
branch
from
3588965 to
fa5072e
Compare
bnjbvr
force-pushed
the
doug/multi-user-power-levels
branch
from
fa5072e to
370f473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having noticed that we were about to queue up calls for multiple members in EX it seemed worth passing in an array. I'm honestly not sure why I didn't originally expose this method in line with the SDK method it calls, but it's fixed now!