Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timeline) - Expose shield state for EventTimelineItem #3679

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

BillCarsonFr
Copy link
Member

Fixes #3667

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@BillCarsonFr BillCarsonFr force-pushed the valere/expose_shields branch from a28f5b6 to 99d342d Compare July 10, 2024 13:35
@BillCarsonFr BillCarsonFr marked this pull request as ready for review July 11, 2024 08:28
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner July 11, 2024 08:28
@BillCarsonFr BillCarsonFr requested review from poljar and removed request for a team July 11, 2024 08:28
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.25%. Comparing base (8e0282a) to head (6e4426a).
Report is 50 commits behind head on main.

Files Patch % Lines
...rates/matrix-sdk-ui/src/timeline/event_item/mod.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3679      +/-   ##
==========================================
- Coverage   84.27%   84.25%   -0.03%     
==========================================
  Files         259      259              
  Lines       26633    26638       +5     
==========================================
- Hits        22446    22444       -2     
- Misses       4187     4194       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar merged commit d9b2b53 into main Jul 11, 2024
61 checks passed
@poljar poljar deleted the valere/expose_shields branch July 11, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Message ShieldState in UI crate for TimelineEventItemId and in ffi Bindings
2 participants