Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some WASM-related refactors #4491

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Some WASM-related refactors #4491

merged 3 commits into from
Jan 9, 2025

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Jan 8, 2025

Not sufficient for compiling the UI crate on WASM, but smaller PRs = better.

Signed-off-by: Jonas Platte [email protected]

@jplatte jplatte requested a review from a team as a code owner January 8, 2025 20:35
@jplatte jplatte requested review from jmartinesp and removed request for a team January 8, 2025 20:35
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.35%. Comparing base (df4b696) to head (61ac3a6).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk-ui/src/timeline/futures.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4491      +/-   ##
==========================================
- Coverage   85.38%   85.35%   -0.03%     
==========================================
  Files         284      284              
  Lines       31885    31885              
==========================================
- Hits        27225    27216       -9     
- Misses       4660     4669       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@poljar poljar merged commit b837865 into main Jan 9, 2025
40 checks passed
@poljar poljar deleted the jplatte/wasm-refactor branch January 9, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants