Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createRoom does *not* support a 'guest_can_join' param #1471

Closed
richvdh opened this issue Aug 2, 2018 · 0 comments
Closed

createRoom does *not* support a 'guest_can_join' param #1471

richvdh opened this issue Aug 2, 2018 · 0 comments
Labels
spec-bug Something which is in the spec, but is wrong

Comments

@richvdh
Copy link
Member

richvdh commented Aug 2, 2018

#1093 added a guest_can_join param to the spec for createRoom, but as per matrix-org/synapse#3421 (review), I believe it was based on a misguided interpretation of the synapse code, and should be removed before the spec is released.
@richvdh richvdh added the spec-bug Something which is in the spec, but is wrong label Aug 2, 2018
@richvdh richvdh mentioned this issue Aug 2, 2018
Closed
turt2live added a commit to turt2live/matrix-doc that referenced this issue Aug 15, 2018
@turt2live
Add general clarity to the /createRoom endpoint
45c68e3 
This commit does a number of things:
* Minor formatting/alignment changes
* Document the room_alias response key. This could be deprecated now, or forfeited, if needed.
* Remove the guest_can_join parameter - it is not actually supported
* Document the previously undocumented power_level_content_override parameter
* Clarify that the room_id is required on the response
* More clearly spell out which events are created as part of the request
* Clarify how the room alias becomes the canonical alias
* Clarify how the `visibility` may be used to determine a default preset to apply
* Document the `m.federate` creation content parameter, adding an option for the homeserver to define a default value

References:
* Preset being inferred by the visibility: https://github.com/matrix-org/synapse/blob/cd32c19a604549b4518d748c07149d140bc9e063/synapse/handlers/room.py#L172-L177
* Power level content overrides:
  * https://github.com/matrix-org/synapse/blob/master/synapse/handlers/room.py#L198
  * https://github.com/matrix-org/synapse/blob/master/synapse/handlers/room.py#L335-L359
* Aliases becoming canonical: https://github.com/matrix-org/synapse/blob/master/synapse/handlers/room.py#L366-L370
* `m.federate` landing in the create event: https://github.com/matrix-org/synapse/blob/master/synapse/handlers/room.py#L311-L315

Fixes https://github.com/matrix-org/matrix-doc/issues/1243
Fixes matrix-org#1471
Inspired by matrix-org#1213
@turt2live turt2live mentioned this issue Aug 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec-bug Something which is in the spec, but is wrong
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richvdh