Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec is wrong for event_match.pattern push rule condition #2637

Closed
richvdh opened this issue Jun 15, 2020 · 2 comments · Fixed by #3690
Closed

spec is wrong for event_match.pattern push rule condition #2637

richvdh opened this issue Jun 15, 2020 · 2 comments · Fixed by #3690
Labels
client-server Client-Server API push spec-bug Something which is in the spec, but is wrong

Comments

@richvdh
Copy link
Member

richvdh commented Jun 15, 2020

https://matrix.org/docs/spec/client_server/r0.6.1#conditions says:

Patterns with no special glob characters should be treated as having asterisks prepended and appended when testing the condition.

This sounds like a disasterous idea (since it would mean rules with a condition of type == 'm.room.message' would also match events of type org.example.m.room.message). Fortunately it appears to be untrue.

(that said: synapse does implement some magic when the match key is content.body, where it searches for the search term anywhere in the event body, but also only matches complete words)

@richvdh
Copy link
Member Author

richvdh commented Jun 15, 2020

@richvdh richvdh added clarification An area where the spec could do with being more explicit client-server Client-Server API push labels Jun 16, 2020
@richvdh richvdh added spec-bug Something which is in the spec, but is wrong and removed clarification An area where the spec could do with being more explicit labels Apr 19, 2021
richvdh added a commit that referenced this issue Feb 17, 2022
@richvdh richvdh linked a pull request Mar 1, 2022 that will close this issue
@richvdh
Copy link
Member Author

richvdh commented Mar 1, 2022

fixed by #3690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API push spec-bug Something which is in the spec, but is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant