Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should room name be limited to 255 bytes? #3641

Closed
aaronraimist opened this issue Jan 13, 2022 · 1 comment · Fixed by #3669
Closed

Should room name be limited to 255 bytes? #3641

aaronraimist opened this issue Jan 13, 2022 · 1 comment · Fixed by #3669
Labels
clarification An area where the spec could do with being more explicit

Comments

@aaronraimist
Copy link
Contributor

aaronraimist commented Jan 13, 2022 •
edited
Loading

Link to problem area: https://spec.matrix.org/v1.1/client-server-api/#mroomname

Issue

The spec says the name field in the m.room.name event must not exceed 255 bytes. Synapse, Dendrite, and Conduit do not enforce this over the C-S API. Is the spec wrong or are the servers wrong?
@aaronraimist aaronraimist added the clarification An area where the spec could do with being more explicit label Jan 13, 2022
@Half-Shot
Copy link
Contributor

Hm, the horse may have bolted by this point. I'd probably vote to remove the requirement (and later add it in a MSC, if we think it's required). Events are obviously limited to 65k, and any sensible client should be trimming excessive names anyway.

@aaronraimist aaronraimist mentioned this issue Jan 23, 2022
Merged
richvdh pushed a commit that referenced this issue Feb 22, 2022
@aaronraimist
Remove unenforced size limit on room names (#3669)
2e63733 
Fixes #3641

The spec says the name field in m.room.name events must not exceed 255 bytes but no servers actually enforce this over the C-S API. Clients should probably already be truncating room names to an appropriate length for their user interface.

Signed-off-by: Aaron Raimist <[email protected]>
RiotTranslateBot pushed a commit to RiotTranslateBot/matrix-doc that referenced this issue Aug 22, 2023
@aaronraimist @turt2live
Remove unenforced size limit on room names (matrix-org#3669)
ac4a296 
Fixes matrix-org#3641

The spec says the name field in m.room.name events must not exceed 255 bytes but no servers actually enforce this over the C-S API. Clients should probably already be truncating room names to an appropriate length for their user interface.

Signed-off-by: Aaron Raimist <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification An area where the spec could do with being more explicit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unenforced size limit on room names aaronraimist/matrix-doc
2 participants
@Half-Shot @aaronraimist