Remove unenforced size limit on room names #3669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Raimist <[email protected]>
Signed-off-by: Aaron Raimist <[email protected]>
richvdh
reviewed
Feb 22, 2022
| @@ -0,0 +1 @@ | |||
| Remove unenforced size limit on the `name` field of `m.room.name` events. | |||
There was a problem hiding this comment.
given we're making this change on the basis that it has never been enforced, this is a clarification rather than a .breaking imho
There was a problem hiding this comment.
Ok. I have switched it to a clarification.
Signed-off-by: Aaron Raimist <[email protected]>
This was referenced May 27, 2022
RiotTranslateBot
pushed a commit
to RiotTranslateBot/matrix-doc
that referenced
this pull request
Aug 22, 2023
Fixes matrix-org#3641 The spec says the name field in m.room.name events must not exceed 255 bytes but no servers actually enforce this over the C-S API. Clients should probably already be truncating room names to an appropriate length for their user interface. Signed-off-by: Aaron Raimist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3641
The spec says the
namefield inm.room.nameevents must not exceed 255 bytes but no servers actually enforce this over the C-S API. Clients should probably already be truncating room names to an appropriate length for their user interface.Alternatively servers could start enforcing the limit.
Preview: https://pr3669--matrix-org-previews.netlify.app