Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark from parameter as optional for /messages #3638

Closed
wants to merge 2 commits into from
Closed

Mark from parameter as optional for /messages #3638

wants to merge 2 commits into from

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Jan 12, 2022 •
edited by github-actions bot
Loading

@germain-gg
Marking from parameter as optional
dabbdba 
As per MSC3567, the `from` parameter is now optional for the `/messages` endpoint to allow fetching first or latest room content without having to rely on `/sync`

#3567
turt2live
turt2live requested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also a changelog entry please :)

Something like:

Make `from` optional on `GET /_matrix/client/v3/messages` as per [MSC3567](https://github.com/matrix-org/matrix-doc/pull/3567).

@germain-gg
Copy link
Contributor Author

also a changelog entry please :)

@turt2live where does that changelog should exist? I've looked at recent merged PRs and it's unclear to me where that should go?

@germain-gg germain-gg requested a review from turt2live January 17, 2022 09:22
@richvdh richvdh changed the title Marking from parameter as optional for /messages Mark from parameter as optional for /messages Jan 17, 2022
@uhoreg
Copy link
Member

uhoreg commented Jan 17, 2022

The changelog goes in changelogs/client_server/newsfragments for changes to the client-server spec. In general, you create a file named <pr_number>., where is one of the types listed in changelogs/pyproject.toml. For example, for this PR, this would probably count as type "feature" ("Backwards compatible changes"), so you would put the changelog line in changelogs/client_server/newsfragments/3638.feature.

turt2live
turt2live reviewed Jan 17, 2022
View reviewed changes
data/api/client-server/message_pagination.yaml
Comment on lines -144 to 151
application/json: {
application/json:
{
"start": "t47429-4392820_219380_26003_2265",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the formatting here and on chunk got changed unexpectedly.

@turt2live turt2live mentioned this pull request Jan 18, 2022
Merged
@richvdh
Copy link
Member

richvdh commented Feb 17, 2022

@gsouquet are you able to update this?

clokep
clokep reviewed Feb 17, 2022
View reviewed changes
data/api/client-server/message_pagination.yaml
@@ -49,6 +49,7 @@ paths:
- in: query
type: string
name: from
x-changedInMatrixVersion: "1.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs to be 1.3 now?

@richvdh
Copy link
Member

richvdh commented Mar 7, 2022

We'll need to reopen this against https://github.com/matrix-org/matrix-spec.

@richvdh richvdh mentioned this pull request Mar 7, 2022
Open
@jplatte jplatte mentioned this pull request Mar 25, 2022
Merged
@jplatte
Copy link
Contributor

jplatte commented Mar 25, 2022

We'll need to reopen this against matrix-org/matrix-spec.

Done: matrix-org/matrix-spec#1002

@jplatte jplatte closed this Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clokep clokep clokep left review comments

@turt2live turt2live turt2live requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@germain-gg @uhoreg @richvdh @jplatte @clokep @turt2live