room_type is not a required parameter in practice (#1110)

* room_type is not a required parameter in practice In practice servers seem to mirror what the room create event does and leave out the room_type when unset. Signed-off-by: Nicolas Werner <[email protected]> * Add changelog Signed-off-by: Nicolas Werner <[email protected]> * Also make room_type and allowed_room_ids optional in the openapi They are optional according to the text, but the openapi marks them as required instead. Signed-off-by: Nicolas Werner <[email protected]> * Fix copy and paste error of newsfragment Signed-off-by: Nicolas Werner <[email protected]>
matrix-org · Jun 7, 2022 · e70045f · e70045f
1 parent 8d82366
commit e70045f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/changelogs/client_server/newsfragments/1110.clarification b/changelogs/client_server/newsfragments/1110.clarification
@@ -0,0 +1 @@
+Fix various typos throughout the specification.
diff --git a/changelogs/server_server/newsfragments/1110.clarification b/changelogs/server_server/newsfragments/1110.clarification
@@ -0,0 +1 @@
+Fix various typos throughout the specification.
diff --git a/data/api/client-server/space_hierarchy.yaml b/data/api/client-server/space_hierarchy.yaml
@@ -149,7 +149,7 @@ paths:
                                     format: int64
                                     description: The `origin_server_ts` for the event.
                                 required: [origin_server_ts]
-                      required: [room_type, children_state]
+                      required: [children_state]
               next_batch:
                 type: string
                 description: |-

diff --git a/data/api/server-server/space_hierarchy.yaml b/data/api/server-server/space_hierarchy.yaml
@@ -158,7 +158,7 @@ paths:
                                   format: int64
                                   description: The `origin_server_ts` for the event.
                               required: [origin_server_ts]
-                    required: [room_type, allowed_room_ids, children_state]
+                    required: [children_state]
               children:
                 type: array
                 description: |-
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix various typos throughout the specification.