Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/createRoom styling is borked #1358

Closed
DMRobertson opened this issue Nov 23, 2022 · 7 comments
Closed

/createRoom styling is borked #1358

DMRobertson opened this issue Nov 23, 2022 · 7 comments
Labels
aesthetic A suggestion or issue relating to the representation of the spec

Comments

@DMRobertson
Copy link
Contributor

Link to problem area: https://spec.matrix.org/v1.5/client-server-api/#post_matrixclientv3createroom

Issue
image
@DMRobertson DMRobertson added the aesthetic A suggestion or issue relating to the representation of the spec label Nov 23, 2022
@DMRobertson
Copy link
Contributor Author

Regressed in 1.4; fine in 1.3.

@DMRobertson
Copy link
Contributor Author

Two oddities:

  • the text of each list item is inside a <p>, which seems like overkill
  • the list items inherit the following style which seems to bork the rendering: 
     summary, slot[name="internal-main-summary"]::slotted(summary) {
   list-style: disclosure-closed inside;
 }

@DMRobertson
Copy link
Contributor Author

DMRobertson commented Nov 23, 2022 •
edited
Loading

Oh I see: all of the guff at the top is inside the <summary>, and the inheritance of styles is meant to give it a more compact display.

If it were up to me I'd move everything except the HTTP Method and Path outside of the details. (It's frequently irritating that collapsing an endpoint you don't care about still leaves you with a big chunk of description that you still don't care about.)

@turt2live
Copy link
Member

related: #1352

@richvdh
Copy link
Member

richvdh commented Nov 25, 2022

also POST /_matrix/client/v3/rooms/{roomId}/invite

@DMRobertson
Copy link
Contributor Author

And also https://spec.matrix.org/v1.6/client-server-api/#mroommember

@DMRobertson DMRobertson mentioned this issue Feb 22, 2023
Merged
@DMRobertson
Copy link
Contributor Author

Pretty sure this is a duplicate of #1352.

@DMRobertson DMRobertson closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2023
@DMRobertson DMRobertson mentioned this issue May 26, 2023
Merged
richvdh pushed a commit that referenced this issue May 30, 2023
Only include titles in summaries (#1549)
48459de 
I previously made this change for HTTP endpoints in #1446. It seems there are
other places where we have over-sized `<summary>` elements. I would like
to elimintate those too, as grumbled about in
#1358 (comment)
and
#1352 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aesthetic A suggestion or issue relating to the representation of the spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @richvdh @DMRobertson