Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include titles in summaries #1549

Merged
merged 2 commits into from
May 30, 2023
Merged

Only include titles in summaries #1549

merged 2 commits into from
May 30, 2023

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented May 26, 2023

I previously made this change for HTTP endpoints in #1446. It seems there are other places where we have over-sized <summary> elements. I would like to elimintate those too, as grumbled about in
#1358 (comment) and
#1352 (comment)

Preview: https://pr1549--matrix-spec-previews.netlify.app

Before:

After:

David Robertson added 2 commits May 26, 2023 11:58
I previously made this change for HTTP endpoints in #1446. It seems there are
other places where we have over-sized `<summary>` elements. I would like
to elimintate those too, as grumbled about in
#1358 (comment)
and
#1352 (comment)
@DMRobertson DMRobertson marked this pull request as ready for review May 26, 2023 11:16
@DMRobertson DMRobertson requested a review from a team as a code owner May 26, 2023 11:16
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm

@richvdh richvdh merged commit 48459de into matrix-org:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants