Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m.room.name's name field is marked as required but is described as possibly absent #1632

Closed
zecakeh opened this issue Sep 12, 2023 · 3 comments · Fixed by #1639
Closed

m.room.name's name field is marked as required but is described as possibly absent #1632

zecakeh opened this issue Sep 12, 2023 · 3 comments · Fixed by #1639
Labels
spec-bug Something which is in the spec, but is wrong

Comments

@zecakeh
Copy link
Contributor

zecakeh commented Sep 12, 2023

Link to problem area: https://spec.matrix.org/v1.8/client-server-api/#mroomname

Issue
The schema of the event says that the name field is required. The description of the event says that the same field can be "absent, null, or empty".

Expected behaviour
It should either be required or not.

For context, Synapse doesn't accept that a client sends this event if the field is not a string.

@zecakeh zecakeh added the spec-bug Something which is in the spec, but is wrong label Sep 12, 2023
@richvdh
Copy link
Member

richvdh commented Sep 18, 2023

The description of the event says that the same field can be "absent, null, or empty".

I'm not sure it says exactly that?

As with all Matrix events, implementations have to behave sensibly when they receive a malformed event. The text I think you are referring to provides some guidance on what implementations should do if they receive an m.room.name event which is (incorrectly) missing a name property.

@zecakeh
Copy link
Contributor Author

zecakeh commented Sep 18, 2023

Ah indeed, I did not understand it like that.

@richvdh
Copy link
Member

richvdh commented Sep 18, 2023

Certainly the wording could be clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-bug Something which is in the spec, but is wrong
Projects
None yet
2 participants