Remove enum for POST /login type definition
#1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the enum is not exhaustive, improve the description of the property instead. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
KitsuneRal
reviewed
Apr 3, 2024
data/api/client-server/login.yaml
Outdated
| This must be a type returned in one of the flows of the | ||
| response of the [`GET /login`](/client-server-api/#get_matrixclientv3login) | ||
| endpoint, like `m.login.password`, `m.login.token` or | ||
| `m.login.sso`. |
There was a problem hiding this comment.
I might be confusing something but I think m.login.sso is never to be found in POST /login, clients should redirect to a dedicated endpoint instead. Am I smoking stuff?
There was a problem hiding this comment.
Indeed, I got influenced by the issue without thinking. It is fixed now.
Signed-off-by: Kévin Commaille <[email protected]>
richvdh
approved these changes
Apr 9, 2024
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the enum is not exhaustive, improve the description of the property instead.
Fixes #825.
Preview: https://pr1776--matrix-spec-previews.netlify.app