Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enum for POST /login type definition #1776

Merged
merged 3 commits into from
Apr 9, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Clarify that the `type` of the `POST /login` request must be one of the types returned by the `GET /login` response.
11 changes: 7 additions & 4 deletions data/api/client-server/login.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,13 @@ paths:
properties:
type:
type: string
enum:
- m.login.password
- m.login.token
description: The login type being used.
description: |-
The login type being used.

This must be a type returned in one of the flows of the
response of the [`GET /login`](/client-server-api/#get_matrixclientv3login)
endpoint, like `m.login.password`, `m.login.token` or
`m.login.sso`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be confusing something but I think m.login.sso is never to be found in POST /login, clients should redirect to a dedicated endpoint instead. Am I smoking stuff?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that's right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I got influenced by the issue without thinking. It is fixed now.

identifier:
$ref: definitions/user_identifier.yaml
user:
Expand Down
Loading