-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We need to decide if trailing slashes are optional on requests #484
Comments
my thoughts on this are as per matrix-org/matrix-spec-proposals#1849 (comment) |
my thoughts are, fairly strongly, that there should be exactly one way to do it. Having two ways to do anything leads us to the situation where:
|
Being a happy developer of a client that generates paths directly from Swagger spec (and we have at least one case of doing the same for servers) I obviously would like that the Swagger definition is strictly followed. That makes the case in matrix-org/matrix-spec-proposals#2061 somewhat stand out: Swagger mandates I agree with Rich that for the sake of consistency across the ecosystem we have to follow exactly one way, and no trailing slashes seems to be a de-facto accepted convention requiring the least number of adjustments. I would also prefer to declare endpoints with trailing slashes as generally a no-go zone within Matrix API, to simplify tracking down bugs in clients where the last parameter on the path is empty. |
See https://github.com/matrix-org/matrix-doc/issues/1944
See matrix-org/matrix-spec-proposals#2061
See matrix-org/matrix-spec-proposals#2097 (comment)
Personally, I'm of the opinion that it should be optional (ie: can be included or excluded).
The text was updated successfully, but these errors were encountered: