Specify some of the common concepts for Matrix in the index #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
requested changes
Jun 10, 2019
| @@ -0,0 +1 @@ | |||
| Clarify that the trailing slash is optional on ``/keys/*`` endpoints when no key ID is requested. | |||
There was a problem hiding this comment.
This doesn't match PR description? Are these changes lost?
There was a problem hiding this comment.
The changes are bundled into this PR. It's just a bit awkward because the meat of the PR isn't in the s2s spec, so the changelog is tightly scoped.
|
(will accept a checkmark from either of you btw) |
erikjohnston
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2061
Fixes #1468
Fixes #1528
The section is not referenced by the specifications yet - they do a fairly good job of explaining it over and over. In future, it would be good to point all the references to the index.
Note: This does not attempt to solve trailing slashes for all endpoints, just the one mentioned in #2061. See https://github.com/matrix-org/matrix-doc/issues/2107 for more details.