Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Federation API spec does not declare fields as required for /_matrix/key/v2/server #613

Closed
valkum opened this issue Apr 22, 2020 · 3 comments · Fixed by #1930
Closed

Federation API spec does not declare fields as required for /_matrix/key/v2/server #613

valkum opened this issue Apr 22, 2020 · 3 comments · Fixed by #1930
Labels
A-S2S Server-to-Server API (federation) clarification An area where the expected behaviour is understood, but the spec could do with being more explicit

Comments

@valkum
Copy link
Contributor

valkum commented Apr 22, 2020 •
edited by richvdh
Loading

in https://matrix.org/docs/spec/server_server/r0.1.3#get-matrix-key-v2-server-keyid does not declare the response fields as required but synapse fails with a KeyError when at least on of the fields is not present.
@turt2live turt2live added A-S2S Server-to-Server API (federation) spec-bug Something which is in the spec, but is wrong labels Apr 22, 2020
@turt2live
Copy link
Member

as mentioned in the conduit room: we probably just forgot to add the "required" label here.

@valkum
Copy link
Contributor Author

valkum commented Apr 22, 2020

Yeah just put that here as a reminder that it gets fixed sometime.

@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@turt2live turt2live changed the title Federation API spec does not declare fields as requiredfor /_matrix/key/v2/server Federation API spec does not declare fields as required for /_matrix/key/v2/server May 28, 2022
@turt2live turt2live added clarification An area where the expected behaviour is understood, but the spec could do with being more explicit spec-problem and removed spec-bug Something which is in the spec, but is wrong labels May 28, 2022
@HPOA909
Copy link

HPOA909 commented Jul 23, 2023

I have this problem, too; when the federation tester is constantly searches through my server for that specific key file.

tulir added a commit that referenced this issue Aug 14, 2024
@tulir
Fix required fields in /_matrix/key/v2/server response schema
a114f21 
Fixes #613

Signed-off-by: Tulir Asokan <[email protected]>
@tulir tulir mentioned this issue Aug 14, 2024
Merged
@tulir tulir closed this as completed in 87de68c Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-S2S Server-to-Server API (federation) clarification An area where the expected behaviour is understood, but the spec could do with being more explicit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix required fields in /_matrix/key/v2/server response schema matrix-org/matrix-spec
4 participants
@valkum @turt2live @richvdh @HPOA909