Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

room_type is not a required parameter in practice #1110

Merged
merged 4 commits into from
Jun 7, 2022
Merged

room_type is not a required parameter in practice #1110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aed0bbd
room_type is not a required parameter in practice
nico-famedly Jun 7, 2022
b71fd6d
Add changelog
nico-famedly Jun 7, 2022
d60878c
Also make room_type and allowed_room_ids optional in the openapi
nico-famedly Jun 7, 2022
b09a715
Fix copy and paste error of newsfragment
nico-famedly Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/client_server/newsfragments/1110.clarification
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix various typos throughout the specification.
1 change: 1 addition & 0 deletions changelogs/server_server/newsfragments/1110.clarification
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix various typos throughout the specification.
2 changes: 1 addition & 1 deletion data/api/client-server/space_hierarchy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ paths:
format: int64
description: The `origin_server_ts` for the event.
required: [origin_server_ts]
required: [room_type, children_state]
required: [children_state]
next_batch:
type: string
description: |-
Expand Down
2 changes: 1 addition & 1 deletion data/api/server-server/space_hierarchy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ paths:
format: int64
description: The `origin_server_ts` for the event.
required: [origin_server_ts]
required: [room_type, allowed_room_ids, children_state]
required: [children_state]
children:
type: array
description: |-
Expand Down