-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec for MSC3077 #1602
Closed
Closed
Spec for MSC3077 #1602
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Add specification for [MSC3077: Multi-stream VoIP](https://github.com/matrix-org/matrix-spec-proposals/pull/3077]. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -171,18 +171,34 @@ In response to an incoming invite, a client may do one of several things: | |
|
||
##### Streams | ||
|
||
Clients are expected to send one stream with one track of kind `audio` (creating a | ||
voice call). They can optionally send a second track in the same stream of kind | ||
`video` (creating a video call). | ||
|
||
Clients implementing this specification use the first stream and will ignore | ||
any streamless tracks. Note that in the JavaScript WebRTC API, this means | ||
`addTrack()` must be passed two parameters: a track and a stream, not just a | ||
track, and in a video call the stream must be the same for both audio and video | ||
track. | ||
|
||
A client may send other streams and tracks but the behaviour of the other party | ||
with respect to presenting such streams and tracks is undefined. | ||
Clients may send more than one stream in a VoIP call. Metadata can be included in | ||
the `m.call.invite`, `m.call.answer` and `m.call.negotiate` events to describe the | ||
richvdh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
streams being sent. This is the `sdp_stream_metadata` field. | ||
richvdh marked this conversation as resolved.
Show resolved
Hide resolved
richvdh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
This field is an object in which each key is one stream `id` in the session | ||
description. The values are objects with the following fields: | ||
|
||
* `purpose` - a string indicating the purpose of the stream. For compatibility | ||
between client the following values are defined: | ||
richvdh marked this conversation as resolved.
Show resolved
Hide resolved
richvdh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* `m.usermedia` - stream that contains the webcam and/or microphone tracks | ||
* `m.screenshare` - stream with the screen-sharing tracks | ||
|
||
If an incoming stream is not described in `sdp_stream_metadata` and | ||
`sdp_stream_metadata` is present, the stream should be ignored. If a stream has | ||
a `purpose` of an unknown type (i.e. not `m.usermedia` or `m.screenshare`), it | ||
should be ignored. | ||
|
||
Clients implementing this specification will ignore any streamless tracks. Note | ||
that in the JavaScript WebRTC API, this means `addTrack()` must be passed two | ||
parameters: a track and a stream, not just a track, and in a video call the | ||
stream must be the same for both audio and video track. | ||
Comment on lines
+191
to
+194
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know this is existing text, but it now seems even more confusing than before, so I think we need to clarify.
|
||
|
||
During the initial invite and answer exchange clients find out if the field | ||
`sdp_stream_metadata` is missing. For backwards compatibility if it is not | ||
present in the event sent by the opponent, the client should ignore any new | ||
richvdh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
incoming streams (i.e. it should use the first one) and it shouldn't send more | ||
than one stream (i.e. clients cannot send a video feed and a screenshare at the | ||
same time, as is the case in current clients). | ||
richvdh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
##### Invitees | ||
The `invitee` field should be added whenever the call is intended for one | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add something to https://pr1602--matrix-spec-previews.netlify.app/client-server-api/#common-fields about the new field?