Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CI scripts dependencies #1786

Merged
merged 6 commits into from
Apr 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/internal/newsfragments/1786.clarification
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Upgrade jsonschema and python-jsonpath CI scripts dependencies.
13 changes: 10 additions & 3 deletions scripts/check-event-schema-examples.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ def import_error(module, package, debian, error):
import_error("jsonschema", "jsonschema", "jsonschema", e)
raise

try:
import referencing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we depend on it, we should add this to requirements.txt, even though it will be pulled in as a transitive dependency in practice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

except ImportError as e:
import_error("referencing", "referencing", "referencing", e)
raise

try:
import yaml
except ImportError as e:
Expand All @@ -56,13 +62,14 @@ def check_example_file(examplepath, schemapath):
with open(schemapath) as f:
schema = yaml.safe_load(f)

# $id as a URI with scheme is necessary to make registry resolver work.
fileurl = "file://" + os.path.abspath(schemapath)
schema["id"] = fileurl
resolver = jsonschema.RefResolver(fileurl, schema, handlers={"file": helpers.load_file_from_uri})
schema["$id"] = fileurl

print ("Checking schema for: %r %r" % (examplepath, schemapath))
try:
validator = jsonschema.Draft202012Validator(schema, resolver)
registry = referencing.Registry(retrieve=helpers.load_resource_from_uri)
validator = jsonschema.validators.Draft202012Validator(schema, registry=registry)
validator.validate(example)
except Exception as e:
raise ValueError("Error validating JSON schema for %r %r" % (
Expand Down
16 changes: 12 additions & 4 deletions scripts/check-json-schemas.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ def import_error(module, package, debian, error):
import_error("jsonschema", "jsonschema", "jsonschema", e)
raise

try:
import referencing
except ImportError as e:
import_error("referencing", "referencing", "referencing", e)
raise

try:
import yaml
except ImportError as e:
Expand Down Expand Up @@ -70,10 +76,12 @@ def add(self, other_report):
self.errors += other_report.errors

def check_example(path, schema, example):
# URI with scheme is necessary to make RefResolver work.
# $id as a URI with scheme is necessary to make registry resolver work.
fileurl = "file://" + os.path.abspath(path)
resolver = jsonschema.RefResolver(fileurl, schema, handlers={"file": helpers.load_file_from_uri})
validator = jsonschema.Draft202012Validator(schema, resolver)
schema["$id"] = fileurl

registry = referencing.Registry(retrieve=helpers.load_resource_from_uri)
validator = jsonschema.validators.Draft202012Validator(schema, registry=registry)

validator.validate(example)

Expand Down Expand Up @@ -128,7 +136,7 @@ def check_schema_file(schema_path):

# Check schema is valid.
try:
validator = jsonschema.Draft202012Validator
validator = jsonschema.validators.Draft202012Validator
validator.check_schema(schema)
except Exception as e:
print(f"Failed to validate JSON schema: {e}")
Expand Down
13 changes: 11 additions & 2 deletions scripts/check-openapi-sources.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ def import_error(module, package, debian, error):
import_error("jsonschema", "jsonschema", "jsonschema", e)
raise

try:
import referencing
except ImportError as e:
import_error("referencing", "referencing", "referencing", e)
raise

try:
import yaml
except ImportError as e:
Expand All @@ -50,8 +56,11 @@ def import_error(module, package, debian, error):


def check_schema(filepath, example, schema):
resolver = jsonschema.RefResolver(filepath, schema, handlers={"file": helpers.load_file_from_uri})
validator = jsonschema.Draft202012Validator(schema, resolver)
# $id as a URI with scheme is necessary to make registry resolver work.
schema["$id"] = filepath

registry = referencing.Registry(retrieve=helpers.load_resource_from_uri)
validator = jsonschema.validators.Draft202012Validator(schema, registry=registry)
validator.validate(example)


Expand Down
14 changes: 13 additions & 1 deletion scripts/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import json
import os
import os.path
import referencing
import urllib.parse
import yaml

Expand Down Expand Up @@ -84,4 +85,15 @@ def load_file_from_uri(path):
else:
# We have to assume it's YAML because some of the YAML examples
# do not have file extensions.
return yaml.safe_load(f)
return yaml.safe_load(f)

def load_resource_from_uri(path):
"""Load a JSON or YAML JSON Schema, as a `referencing.Resource` object, from
a file:// URI.
"""
contents = load_file_from_uri(path)
resource = referencing.Resource(
contents=contents,
specification=referencing.jsonschema.DRAFT202012
)
return resource
7 changes: 4 additions & 3 deletions scripts/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
# no doubt older versions would be fine for many of these but these were
# current at the time of writing

# we need at least version 4.0.0 for support of JSON Schema Draft 2020-12.
jsonschema == 4.17.3
# we need at least version 4.18.0 for support of referencing library.
jsonschema >= 4.18.0
referencing >= 0.28.4

python-jsonpath == 0.9.0
python-jsonpath >= 1.0.0
attrs >= 23.1.0
PyYAML >= 3.12
requests >= 2.18.4
Expand Down
Loading