-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pattern formats for patternProperties
#1796
Conversation
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks really nice but I feel a bit uneasy that we end up with same regexes spelled out two times, in different files. And I might be missing something but you don't seem to actually use pattern
defined in custom-formats.yaml
?
Personally not sure if this change makes sense, given that column is meant to show the data type. |
As said in the docs of the file, the regex is only here as a reference to help for creating new |
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I realised we didn't reply to this (pro-tip: comments on the diff are more likely to get noticed than comments on the PR itself). Given this is JSON, the only thing that can be used as an object key is a string. I don't think there is any need to specify |
The idea here is to be able to identify more easily what strings represent in the rendered spec.
If this is accepted, then we can chose most
additionalProperties
topatternProperties
throughout the specification. We can even extend the support to the regularformat
key on string properties.Here is what that changes in the rendered specification, for
m.receipt
:Before:
After:
Preview: https://pr1796--matrix-spec-previews.netlify.app