Replace deprecated Page.Dir with Page.File.Dir #988
Conversation
Page.Dir has been deprecated for a while, and was finally removed in hugo v0.93.0. This commit replaces instances of Page.Dir with Page.File.Dir.
| {{ $page := .Site.GetPage (path.Join .Page.File.Dir "modules" (printf "%s%s" $name ".md"))}} |
There was a problem hiding this comment.
I'm not 100% sure where the changelog for this PR's changes should go...
There was a problem hiding this comment.
we don't have a changelog place for this PR's changeset.
There was a problem hiding this comment.
the changes look good, and it appears as though Hugo fixed whatever was causing this to not work on Windows. The deprecated version was previously chosen for compatibility reasons.
Can we also bump the minimum required version in the README (currently v0.74) to prevent future issues? Arbitrarily setting it to v0.93 would be fine, I think.
anoadragon453
force-pushed
the
anoa/page_dir_deprecation_fix
branch
from
71f2455 to
8275bc5
Compare
|
@turt2live bumped min hugo to v0.93.0 in the README and switched our CI to the latest release (v0.93.3). |
|
(please don't rebase after review has been given - it makes things difficult. Merge commits will be squashed out of existence when the PR is merged) |
|
(Apologies! I had rewritten a commit that hadn't yet been reviewed, hence assuming it was fine.) |
Fixes #986 (which has a bit more context).
Page.Dirhas been deprecated for a while, calling them raised an error in hugo v0.92.0, before it was finally removed in hugo v0.93.0.This commit replaces instances of
Page.DirwithPage.File.Dir.Preview: https://pr988--matrix-spec-previews.netlify.app