Navbar collapse fix #2180 #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tawandamoyo
force-pushed
the
navbar-collapse
branch
from
d69ae50 to
200d68d
Compare
|
Hej @tawandamoyo that PR was quite interesting, why did you close it :) ? |
tawandamoyo
force-pushed
the
navbar-collapse
branch
from
200d68d to
3ef5f52
Compare
|
hey @thibaultamartin , I had realised there was a mistake and was fixing it. I have pushed the (hopefully corrected) new changes now. |
|
Awesome! Today we are holding the website office hours at 16:00 UTC / 17:00 CET. Feel free to join us if you want! This is not a requirement to get your PR merged in, but it's always nice to have new folks around :) |
would be thrilled to join in! |
thibaultamartin
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2180
navBug.mp4