Add support for native E2E #186
Conversation
|
The test failures are due to matrix-bot-sdk now depending on Node 14+ or greater, I am not sure how comfortable you folks are with increasing the minimum node version, but 12 is due to be EOL by April this year anyway.. |
|
I've been asking around and nobody seems to mind too much if we switch to Node 14+. |
| client = new MatrixClient(config.homeserverUrl, config.accessToken, storage, cryptoStorage); | ||
| if (config.encryption.enabled) { | ||
| const joinedRooms = await client.getJoinedRooms(); | ||
| await client.crypto.prepare(joinedRooms); |
There was a problem hiding this comment.
Does this need to be done only at startup?
We'll probably want to apply this treatment also to the various instances of MatrixClient we use in tests.
There was a problem hiding this comment.
I believe this only needs to be done at startup, afterwards the client should manage the joined room list internally.
Needed to merge #186 & node 12 is approaching EOL.
|
Let's wait until we have #192 for testing. |
Needed to merge #186 & node 12 is approaching EOL.
|
@Half-Shot Could you rebase and retry? We have fixed numerous issues on CI, I hope things will be run smoother now. |
|
@Yoric I had a go but I think it's very busted for me. I had to modify the test setup code a bit because we need to extract an access token out of /register for the E2EE stuff to work. |
|
@Half-Shot Is there anything we can do to help? |
|
Whats the state on this? |
|
Fixed by #528 |
Fixes #185
This PR adds support for the new native E2E built into the bot-sdk, which removes the need for pan. I've tested this works locally, but it's not extensively battle tested. I've also:
This could potentially be enabled by default, but I didn't want to change things for existing users.
I cribbed from https://github.com/turt2live/matrix-bot-sdk/blob/master/examples/encryption_bot.ts when writing this code.