Add command to elevate a user (or the bot) as room administrator #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoric
reviewed
Feb 9, 2022
Also use getRoomStateEvent to fetch the actual m.room.power_levels state event.
Also update tests to call done() in case the command is not enabled in the config.
- Textual description/error messages changes - Make the command disabled by default
|
@maranda When you're ready for another review, don't forget to ping me :) |
|
@Yoric ready :) |
Yoric
approved these changes
Feb 23, 2022
|
@Yoric 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #126. I added tests yet as of now only the first self test works the second never does, fwiw I passed hours checking the correctness of the code (tried dozens and dozens of variants) and that there's not an error on my part.
The problem always happen when getFirstReaction() gets called on the second test, the message gets sent correctly in the management room, yet Mjolnir doesn't seem to pick it up.. So the problem looks to be into the mx-tester's boilerplate at this rate.