Unbitrotting ruleserver tests #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnuxie
reviewed
Nov 15, 2022
Comment on lines
+62
to
+63
| let config = configRead(); | ||
| if (!config?.web?.ruleServer?.enabled) { |
There was a problem hiding this comment.
I believe that this.mjolnir will exist in the beforeAll hook, but this works too
There was a problem hiding this comment.
In my experience, it didn't seem to exist.
| await badUser.sendMessage(unprotectedRoom, {msgtype: 'm.text', body: 'Something bad and mean'}); | ||
|
|
||
| await waitForRuleChange(this.config.web.address, this.mjolnir.config.web.port, async () => { |
There was a problem hiding this comment.
I think you have forgot to add the change to waitForRuleChange?
There was a problem hiding this comment.
Turns out that waitForRuleChange had already been refactored, just not its call sites.
| import config from "../../src/config"; | ||
| import { read as configRead } from "../../src/config"; |
There was a problem hiding this comment.
to prevent this from happening again, the test should be added to the end of tsconfig.json.
Yoric
force-pushed
the
yoric/ruleserver-tests
branch
from
6ee94d2 to
a7e1065
Compare
Yoric
force-pushed
the
yoric/ruleserver-tests
branch
from
a7e1065 to
96066ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.