Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not interrupt redact sequences because of exceptions on backfilling #479

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

maranda
Copy link
Contributor

@maranda maranda commented May 2, 2023

Self explanative, do not interrupt the loop and just carry on with the remaining entries in the queue.

src/utils.ts Outdated Show resolved Hide resolved
Gnuxie added a commit to the-draupnir-project/Draupnir that referenced this pull request May 3, 2023
…illing (#50)

* Do not interrupt redact sequences due to error when backfilling

... Mainly timeouts.

* Change caught redaction error LogLevel from DEBUG to ERROR.

From matrix-org/mjolnir#479

---------

Co-authored-by: Marco Cirillo <[email protected]>
@H-Shay
Copy link
Contributor

H-Shay commented Jul 24, 2024

@turt2live - any issues with merging this (modulo the use of victim, which I can fix)? It LGTM

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me as a thing.

We might need to sanitize error a bit, but better to see it used in practice I think.

@H-Shay H-Shay merged commit 1ffde55 into matrix-org:main Jul 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants