Docstring & fix changelog for get_version_number #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
approved these changes
Nov 2, 2021
| An example probably illustrates best. Testing locally, I get | ||
| `[email protected] (b=dmr/version-in-sentry,05e1fa8,dirty)`. | ||
| If this wasn't done from within the repository, I'd just get `[email protected]`. | ||
|
|
||
| Implementation nicked from Synapse. |
There was a problem hiding this comment.
Aside: I really wish we'd start a new library for things that are shared between our projects, rather than have two or three copies to maintain.
(there used to be a syutil project. It got old.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#453, but with bells on.