-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docstring & fix changelog for get_version_number #454
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
Include Sydent's version number when reporting to Sentry. | ||
Include Sydent's version number (and git commit hash if available) when reporting to Sentry. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Include Sydent's version number (and git commit hash if available) when reporting to Sentry. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,15 @@ | |
def get_version_string() -> str: | ||
"""Calculate a git-aware version string for sydent. | ||
|
||
The version string is `[email protected]`, where `x.y.z` comes from | ||
`sydent.__version__`. If the `sydent` module belongs to a git repository on | ||
disk, we the current branch, tag and commit hash, plus a flag to indicate | ||
if the working tree is dirty. | ||
|
||
An example probably illustrates best. Testing locally, I get | ||
`[email protected] (b=dmr/version-in-sentry,05e1fa8,dirty)`. | ||
If this wasn't done from within the repository, I'd just get `[email protected]`. | ||
|
||
Implementation nicked from Synapse. | ||
""" | ||
version_string = sydent.__version__ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside: I really wish we'd start a new library for things that are shared between our projects, rather than have two or three copies to maintain.
(there used to be a syutil project. It got old.)