Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docstring & fix changelog for get_version_number #454

Merged
merged 1 commit into from
Nov 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion changelog.d/453.misc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Include Sydent's version number when reporting to Sentry.
Include Sydent's version number (and git commit hash if available) when reporting to Sentry.
1 change: 1 addition & 0 deletions changelog.d/454.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Include Sydent's version number (and git commit hash if available) when reporting to Sentry.
9 changes: 9 additions & 0 deletions sydent/util/versionstring.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,15 @@
def get_version_string() -> str:
"""Calculate a git-aware version string for sydent.

The version string is `[email protected]`, where `x.y.z` comes from
`sydent.__version__`. If the `sydent` module belongs to a git repository on
disk, we the current branch, tag and commit hash, plus a flag to indicate
if the working tree is dirty.

An example probably illustrates best. Testing locally, I get
`[email protected] (b=dmr/version-in-sentry,05e1fa8,dirty)`.
If this wasn't done from within the repository, I'd just get `[email protected]`.

Implementation nicked from Synapse.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: I really wish we'd start a new library for things that are shared between our projects, rather than have two or three copies to maintain.

(there used to be a syutil project. It got old.)

"""
version_string = sydent.__version__
Expand Down