Catch EmailAddressExceptions and return 400
#464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 10, 2021 20:00
because the source address is part of the application config. (It should really be validated once at startup IMO.)
clokep
reviewed
Nov 11, 2021
added 4 commits
November 11, 2021 20:30
clokep
suggested changes
Nov 12, 2021
added 5 commits
November 12, 2021 15:06
I'd rather put the comment next to the code that checks it
I thought `raise expr from e` would include `e`'s string representation, but it doens't; rather `raise expr from e` seems to replace all mention of `e` and its stack frames from the traceback.
clokep
reviewed
Nov 12, 2021
sydent/util/emailutils.py
Outdated
| @@ -129,6 +125,25 @@ def sendEmail( | |||
| raise EmailSendException() from origException | |||
|
|
|||
|
|
|||
| def check_valid_email_address(address: str, allow_description: bool = True) -> None: | |||
There was a problem hiding this comment.
Does this want allow_description to default to False?
There was a problem hiding this comment.
Argh, it does. Thank you, I need to slow down and think more carefully.
DMRobertson
force-pushed
the
dmr/store-invalid-reject-bad-emailaddr
branch
from
40890cd to
b101614
Compare
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #451