Declare missing dependencies #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
reviewed
Dec 14, 2021
setup.py
Outdated
Comment on lines
60
to
64
| "flake8-pyi==20.10.0", | ||
| "flake8==3.9.2", | ||
| "isort==5.8.0", | ||
| "mypy>=0.902", | ||
| "mypy-zope>=0.3.1", | ||
| "mypy>=0.902", |
There was a problem hiding this comment.
Same deal, I'd probably put mypy above mypy-zope, & similar for flake8
setup.py
Outdated
| @@ -45,14 +45,17 @@ def read(fname): | |||
| "jinja2>=3.0.0", | |||
| "netaddr>=0.7.0", | |||
| "phonenumbers>=8.12.32", | |||
| "PyNaCl>=1.2.1", | |||
| "pyopenssl", | |||
There was a problem hiding this comment.
Any idea about a version bound here?
There was a problem hiding this comment.
I'll copy the one from synapse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's best to look at the commits separately.
The first commit sorts the list of dependencies.