Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare missing dependencies #474

Merged
merged 4 commits into from
Dec 14, 2021
Merged

Declare missing dependencies #474

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3f35c5
Sort dependencies
Dec 14, 2021
e41d2ca
Add missing dependencies to `setup.py`
Dec 14, 2021
10b711b
Fix bad sorting
Dec 14, 2021
975c2e2
Add lower bound for pyOpenSSL version
Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,32 +41,32 @@ def read(fname):
description="Reference Matrix Identity Verification and Lookup Server",
python_requires=">=3.6",
install_requires=[
"attrs>=19.1.0",
"jinja2>=3.0.0",
"signedjson==1.1.1",
"unpaddedbase64>=1.1.0",
"Twisted>=18.4.0",
# twisted warns about about the absence of this
"service_identity>=1.0.0",
"netaddr>=0.7.0",
"phonenumbers>=8.12.32",
"pyopenssl",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea about a version bound here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll copy the one from synapse

"attrs>=19.1.0",
"netaddr>=0.7.0",
"sortedcontainers>=2.1.0",
"pyyaml>=3.11",
# twisted warns about about the absence of this
"service_identity>=1.0.0",
"signedjson==1.1.1",
"sortedcontainers>=2.1.0",
"Twisted>=18.4.0",
"unpaddedbase64>=1.1.0",
],
extras_require={
"dev": [
"parameterized==0.8.1",
"flake8==3.9.2",
"flake8-pyi==20.10.0",
"black==21.6b0",
"flake8-pyi==20.10.0",
"flake8==3.9.2",
"isort==5.8.0",
"mypy>=0.902",
"mypy-zope>=0.3.1",
"mypy>=0.902",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same deal, I'd probably put mypy above mypy-zope, & similar for flake8

"parameterized==0.8.1",
"types-Jinja2",
"types-mock",
"types-PyOpenSSL",
"types-PyYAML",
"types-mock",
],
},
# make sure we package the sql files
Expand Down