Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to unbind using sid/client_secret #160

Merged
merged 3 commits into from
May 22, 2019
Merged

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented May 21, 2019

Closes #134

Adds the ability to give sid and client_secret fields to POST /_matrix/identity/api/v1/3pid/unbind such that a requester can unbind a bound 3PID without having to be the original HS.

Tested manually.

@anoadragon453 anoadragon453 requested a review from a team May 21, 2019 18:28
@anoadragon453 anoadragon453 merged commit 86ca07a into master May 22, 2019
@anoadragon453 anoadragon453 deleted the anoa/unbind_via_sid branch May 22, 2019 12:51
turt2live added a commit to matrix-org/matrix-spec-proposals that referenced this pull request May 28, 2019
As per [MSC1915](#1915)

Implementation proof: 
* matrix-org/synapse#4982
* matrix-org/sydent#160

The only alteration made which differs from the proposal is clarity on how to handle homeservers not knowing the `id_server`. All other differences are unintentional.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MSC 1915 unbind via sid
2 participants