Add mypy.ini, mypy-zope-plugin

changelog.d/357.misc

@@ -0,0 +1 @@
+Add a mypy.ini and add missing modules to ignore, add mypy-zope plugin, remove inline type-ignore comments, and update sydent/utils/emailutils.py. 

pyproject.toml

@@ -38,4 +38,23 @@
 profile = "black"
 
 [tool.black]
-target-version = ['py36']
+target-version = ['py36']
+
+[tool.mypy]
+show_error_codes = true
+namespace_packages = true
+
+[[tool.mypy.overrides]]
+module = [
+    "idna",
+    "nacl.*",
+    "netaddr",
+    "OpenSSL",
+    "prometheus_client",
+    "phonenumbers",
+    "signedjson.*",
+    "sortedcontainers",
+    "unpaddedbase64"
+]
+ignore_missing_imports = true
+

setup.py

@@ -56,6 +56,8 @@ def read(fname):
         "flake8==3.9.2",
         "black==21.5b1",
         "isort==5.8.0",
+        "mypy>=0.900",
+        "mypy-zope @ https://[email protected]/Shoobx/mypy-zope/archive/391ce347b6c01dbc89e0194b62e47deadf53fbc6.tar.gz",
     ],
     # make sure we package the sql files
     include_package_data=True,

sydent/db/threepid_associations.py

@@ -22,6 +22,7 @@
 if TYPE_CHECKING:
     from sydent.sydent import Sydent
 
+
 logger = logging.getLogger(__name__)
 
 

sydent/hs_federation/verifier.py

@@ -21,7 +21,7 @@
 from signedjson.sign import SignatureVerifyException
 from twisted.internet import defer
 from twisted.web.server import Request
-from unpaddedbase64 import decode_base64  # type: ignore
+from unpaddedbase64 import decode_base64
 
 from sydent.http.httpclient import FederationHttpClient
 from sydent.util.stringutils import is_valid_matrix_server_name

sydent/replication/peer.py

@@ -25,7 +25,7 @@
 from twisted.internet.defer import Deferred
 from twisted.web.client import readBody
 from twisted.web.iweb import IResponse
-from unpaddedbase64 import decode_base64  # type: ignore
+from unpaddedbase64 import decode_base64
 
 from sydent.config import ConfigError
 from sydent.db.hashing_metadata import HashingMetadataStore

sydent/threepid/signer.py

@@ -14,7 +14,7 @@
 
 from typing import TYPE_CHECKING, Any, Dict
 
-import signedjson.sign  # type: ignore
+import signedjson.sign
 
 if TYPE_CHECKING:
     from sydent.sydent import Sydent

sydent/util/emailutils.py

@@ -119,9 +119,7 @@ def sendEmail(
         smtp.quit()
     except Exception as origException:
         twisted.python.log.err()
-        ese = EmailSendException()
-        ese.cause = origException
-        raise ese
+        raise EmailSendException() from origException
 
 
 class EmailAddressException(Exception):