Make sydent.util pass mypy --strict
#418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
force-pushed
the
dmr/mypy-util
branch
from
018f0fe to
a56ef98
Compare
added 11 commits
October 14, 2021 12:58
DMRobertson
force-pushed
the
dmr/mypy-util
branch
from
bed9944 to
8ef46f4
Compare
|
I bumped the unpaddedbase64 version to pull in a version that has type hints. I don't think that's a problem, but would appreciate it if someone could confirm! |
I did that upgrade; there are no functional or API changes, just typing, so the new constraint should be fine. |
babolivier
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #416 and #417.