Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sydent.validators pass mypy --strict #425

Merged
merged 7 commits into from
Oct 15, 2021
Merged

Make sydent.validators pass mypy --strict #425

merged 7 commits into from
Oct 15, 2021

Conversation

DMRobertson
Copy link
Contributor

Splitting apart ValidationSession and ValidationSessionWithTokenAuth is a bit clunky, but it makes it explicit when we expect token and sendAttemptNumber.

@DMRobertson DMRobertson requested a review from a team October 14, 2021 19:09
clokep
clokep reviewed Oct 14, 2021
View reviewed changes
sydent/db/valsession.py Outdated Show resolved Hide resolved
clokep
clokep reviewed Oct 14, 2021
View reviewed changes
sydent/db/valsession.py Outdated Show resolved Hide resolved
@DMRobertson DMRobertson requested a review from clokep October 14, 2021 19:49
@DMRobertson DMRobertson requested a review from clokep October 15, 2021 15:48
@DMRobertson
Copy link
Contributor Author

Many thanks for reviewing @clokep!

@DMRobertson DMRobertson merged commit 57ba780 into main Oct 15, 2021
@DMRobertson DMRobertson deleted the dmr/mypy-validation branch October 15, 2021 16:31
@callahad callahad mentioned this pull request Oct 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clokep clokep clokep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DMRobertson @clokep